Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action execution fails if worker-created output directory is deleted #46

Closed
asuffield opened this issue Apr 7, 2020 · 0 comments
Closed

Comments

@asuffield
Copy link
Contributor

This appears to have been introduced by #41 (testing without that commit makes the problem go away). The output directory is now created by the worker, but filesystem.Directory follows the fd instead of the path, so the worker will only try to upload the precise directory it created.

If the action does something like this:

rmdir out
mkdir out

Then the action will fail, reporting that the output directory could not be found.

Notably, @io_bazel_rules_go//:stdlib does this.

asuffield added a commit to asuffield/bb-remote-execution that referenced this issue Apr 9, 2020
…ildbarn#46)

Refactor this code so that we can run the same logic before and after
execution: once to create the output directories, then again to find
them by path. This lets us handle the case where the action deletes
and recreates the directory.
asuffield added a commit to asuffield/bb-remote-execution that referenced this issue Apr 9, 2020
…ildbarn#46)

Refactor this code so that we can run the same logic before and after
execution: once to create the output directories, then again to find
them by path. This lets us handle the case where the action deletes
and recreates the directory.
asuffield added a commit to asuffield/bb-remote-execution that referenced this issue May 12, 2020
…ildbarn#46)

Refactor this code so that we can run the same logic before and after
execution: once to create the output directories, then again to find
them by path. This lets us handle the case where the action deletes
and recreates the directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant