Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get username from HTTP request headers when buildbot is served by frontend webserver #266

Merged
merged 2 commits into from
Oct 9, 2011
Merged

Get username from HTTP request headers when buildbot is served by frontend webserver #266

merged 2 commits into from
Oct 9, 2011

Commits on Oct 6, 2011

  1. Add support for getting HTTP username 

    Sometimes it may be useful to run WebStatus through standalone
webserver that may be configured for HTTP authentication (for
example in corporate network it may use LDAP to authenticate users).
In such cases it's reasonable to trust webserver and instead of
asking for username and password for actions like trigger build,
just get username from HTTP headers.
    @paroga
    paroga committed Oct 6, 2011
    Configuration menu
    Copy the full SHA
    0ec7159 View commit details
    Browse the repository at this point in the history

  2. Hide "username" field when HTTP authentication is enabled 

    In case if username is already known from HTTP request headers, there
is no sense to ask user to enter it again. This adds needUserForm
method to Authz class and modifies the authFormIfNeeded template to
hide the username field if not needed.
    @paroga
    paroga committed Oct 6, 2011
    Configuration menu
    Copy the full SHA
    31ff088 View commit details
    Browse the repository at this point in the history