Log scroll bug #3597
Merged
Log scroll bug #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3597 +/- ##
======================================
Coverage 88.3% 88.3%
======================================
Files 323 323
Lines 33891 33891
======================================
Hits 29927 29927
Misses 3964 3964Continue to review full report at Codecov.
|
tardyp
force-pushed
the
log_scroll_bug
branch
from
2ac42e2
to
2915965
Compare
It looks like this hack is reponsible for bug that makes the log viewer always scroll up We also not try to call the backend when we know we are already loading stuff, which makes the UI much more smooth.
tardyp
force-pushed
the
log_scroll_bug
branch
from
2915965
to
00da5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master/buildbot/newsfragmentdirectory (and read theREADME.txtin that directory)