Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerated property not being tested #238

Closed
atomczak opened this issue Feb 1, 2024 · 1 comment
Closed

Enumerated property not being tested #238

atomczak opened this issue Feb 1, 2024 · 1 comment
Labels

Comments

@atomczak
Copy link
Contributor

atomczak commented Feb 1, 2024

Those three test cases appear to be checking the enumerated property, which I understand should be the XSD restriction on the value, allowing one of a few possible values. Those restrictions are not applied in any of the three IDS files:

https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases/property/pass-any_matching_value_in_an_enumerated_property_will_pass_1_3.ids

https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases/property/pass-any_matching_value_in_an_enumerated_property_will_pass_2_3.ids

https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases/property/fail-any_matching_value_in_an_enumerated_property_will_pass_3_3.ids

I was expecting to see something like this:

<ids:property minOccurs="1" maxOccurs="unbounded" datatype="IFCTEXT">
    <ids:propertySet>
        <ids:simpleValue>test_set</ids:simpleValue>
    </ids:propertySet>
    <ids:name>
        <ids:simpleValue>PropName</ids:simpleValue>
    </ids:name>
    <ids:value>
        <xs:restriction>
            <xs:enumeration value="ValueA"/>
            <xs:enumeration value="ValueB"/>
        </xs:restriction>
    </ids:value>
</ids:property>
@atomczak atomczak added the tests label Feb 1, 2024
@CBenghi
Copy link
Contributor

CBenghi commented Feb 27, 2024

Hello @atomczak,

I think in those examples the enumeration is in the IFC file.

#7=IFCWALL('2nJrDaLQfJ1QPhdJR0o97J',$,$,$,$,$,$,$,$);
#8=IFCPROPERTYSET('16MocU_IDOF8_x3Iqllz0d',$,'Pset_WallCommon',$,(#11));
#9=IFCRELDEFINESBYPROPERTIES('1xdwj8qGXK4hzoNbvMdXJW',$,$,$,(#7),#8);
#10=IFCPROPERTYENUMERATION('Status',(IFCLABEL('NEW'),IFCLABEL('EXISTING'),IFCLABEL('DEMOLISH'),IFCLABEL('TEMPORARY'),IFCLABEL('OTHER'),IFCLABEL('NOTKNOWN'),IFCLABEL('UNSET')),$);
#11=IFCPROPERTYENUMERATEDVALUE('Status',$,(IFCLABEL('EXISTING'),IFCLABEL('DEMOLISH')),#10);

@CBenghi CBenghi closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants