Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 testcases have .html file instead of .ifc #310

Closed
rubendel opened this issue Jun 4, 2024 · 2 comments
Closed

2 testcases have .html file instead of .ifc #310

rubendel opened this issue Jun 4, 2024 · 2 comments

Comments

@rubendel
Copy link
Contributor

rubendel commented Jun 4, 2024

The following two test cases have a .html file instead of a .ifc file.

property\pass-floating_point_numbers_are_compared_with_a_1e_6_tolerance_1_4
property\pass-floating_point_numbers_are_compared_with_a_1e_6_tolerance_2_4
@andyward
Copy link
Contributor

andyward commented Jun 6, 2024

Looks to me that these 2 tests should be deleted since the more comprehensive Floating point tests are now in the tolerance folder.

atomczak added a commit that referenced this issue Jun 10, 2024
@atomczak
remove redundant tolerance tests
3704984 
#310
@atomczak
Copy link
Contributor

Apologies, my bad; missed the two tests while implementing tolerance tests at the last minute.

atomczak added a commit that referenced this issue Jun 10, 2024
@atomczak
remove redundant tolerance tests
fd95d2b 
As per #310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rubendel @andyward @atomczak