Cannot perform docker run with volume mounts inside step

[noizwaves]

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes:
Helm 3.2.1
Kubernetes 1.15.11 (AWS EKS)

Which chart:
CHART: agent-0.3.14
APP VERSION: 3.17.0

What happened:
When running a step that includes a Docker run with mounted volumes, the volumes fail to be mounted.

When running the below example, the job output shows this:

trap 'kill -- $$' INT TERM QUIT; touch foobar
--
  | docker run \
  | -w /code \
  | -v `pwd`:/code \
  | --entrypoint=/bin/sh \
  | gardendev/garden-aws:v0.11.14 -c "ls -al"
  |  
  |  
  | total 0
  | drwxr-xr-x    2 root     root             6 May 21 22:26 .
  | drwxr-xr-x    1 root     root            18 May 22 01:44 ..

What you expected to happen:

I expect there to 3 entries in the ls output, but foobar is missing.

How to reproduce it (as minimally and precisely as possible):

steps:
  - label: "Perform a docker run with mounted volume"
    command: |
      touch foobar
      docker run \
        -w /code \
        -v `pwd`:/code \
        --entrypoint=/bin/sh \
        gardendev/garden-aws:v0.11.14 -c "ls -al"

Anything else we need to know:

We are using a very simple configuration for the chart, setting only agent.meta, privateSshKey and agent.token.

We also tried enabling DinD (via setting dind.enabled to true), but that did not resolve the issue.

[noizwaves]

We also found https://buildkite.com/docs/agent/v3/docker#allowing-builds-to-use-docker these instructions for the Docker provisioned agents; are there similar instructions for the Helm Chart provisioned agents?

[tjwallace]

Try these changes, they mount a shared directory between the agent and DinD:
98622d1

[noizwaves]

@tjwallace many thanks for linking this commit. We ended up switching away from the Helm deployed agents to Cloudformation Stack deployed agents, but if I can find time after your PR merges, I'll give the chart another go.

[rimusz]

closing this issue, @noizwaves open a new issue if that doesn't work for you