Add some aceptance tests for the pipeline resource #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2021
yob
force-pushed
the
acceptance-test-pipelines
branch
2 times, most recently
from
c42478f
to
6d881a5
Compare
yob
changed the title
This resource had no acceptance tests, and we were nervous about the risk of regressions. This adds a few initial test cases: * creating a pipeline with only the required attributes set * creating a pipeline with all attributes set * updating a pipeline * importing an existing pipeline Pipeline deletion is tested implicitly when the terraform testing sdk cleans up after a test. We assume there's potential for more tests that exercise specific combinations (for example, exposing this teams related bug in pipeline creation #84), but this is a good start. Co-authored-by: Chloe <chloe@buildkite.com>
yob
force-pushed
the
acceptance-test-pipelines
branch
from
6d881a5
to
c88455d
Compare
|
I've run the full acceptance test suite locally and confirmed it is green 👍 |
chloeruka
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource had no acceptance tests, and we were nervous about the risk of regressions.
This adds a few initial test cases:
Pipeline deletion is tested implicitly when the terraform testing sdk cleans up after a test.
We assume there's potential for more tests that exercise specific combinations (for example, exposing this teams related bug in pipeline creation #84), but this is a good start