Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract over WebError #19

Closed
gabro opened this issue Mar 23, 2016 · 2 comments
Closed

Abstract over WebError #19

gabro opened this issue Mar 23, 2016 · 2 comments
Assignees
@calippo
Labels
enhancement

Comments

@gabro
Copy link
Member

gabro commented Mar 23, 2016

requirements

The WebError family is rather arbitrary.
We should allow defining custom errors.
@calippo calippo self-assigned this Apr 12, 2016
@calippo calippo assigned gabro and unassigned calippo Apr 12, 2016
@calippo
Copy link
Member

calippo commented Apr 12, 2016 •
edited
Loading

I'm currently experiencing this very issue.

Does WebError really needs to be defined as sealed?
Each web service handle errors in its own way, I don't think it makes sense to force a predefined structure.
Ok... we're losing control on MatchError, but this lack of flexibility is really frustrating.

Another solution would be to create a "free text error", but I don't think it's safer than a run-time MatchError.

@gabro gabro removed their assignment Apr 18, 2016
@calippo calippo self-assigned this Jul 27, 2016
@calippo calippo mentioned this issue Jul 27, 2016
Merged
@calippo
Copy link
Member

calippo commented Jul 27, 2016

Closed in #24

@calippo calippo closed this as completed Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calippo calippo

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabro @calippo