Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov for Windows #967

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Add codecov for Windows #967

merged 2 commits into from
Jan 19, 2021

Conversation

dfreilich
Copy link
Member

@dfreilich dfreilich commented Nov 30, 2020

This is a draft PR (not an actual draft, in order to run actions and get the codecov result we are trying for), to see whether we can find any more information on our codecov failures using the verbose flag. It was requested on the codecov forums here

After working through the codecov forum suggestions, we are using the codecov.exe uploader for Windows, which seems to work as it should.

Related:

Resolves #906
Is an extension of #944, which I can't reopen because I've force-pushed this branch to be up-to-date with origin/main

@dfreilich dfreilich requested a review from a team as a code owner November 30, 2020 10:57
@dfreilich dfreilich marked this pull request as draft December 22, 2020 08:55
@dfreilich dfreilich marked this pull request as ready for review January 11, 2021 19:10
@dfreilich dfreilich force-pushed the verbose-codecov branch 2 times, most recently from 8bd1ea2 to 46af04f Compare January 11, 2021 19:28
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #967 (d6335c3) into main (5eb3093) will increase coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
+ Coverage   79.59%   80.04%   +0.46%     
==========================================
  Files         130      130              
  Lines        5799     7989    +2190     
==========================================
+ Hits         4615     6394    +1779     
- Misses        760     1175     +415     
+ Partials      424      420       -4     
Flag Coverage Δ
os_linux 79.59% <ø> (ø)
os_macos 76.95% <ø> (ø)
os_windows 79.39% <ø> (?)
unit 79.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dfreilich dfreilich force-pushed the verbose-codecov branch 3 times, most recently from ace9fdc to 5683b58 Compare January 14, 2021 11:01
Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich dfreilich changed the title [DRAFT] Verbose codecov Add codecov for Windows Jan 18, 2021
@dfreilich dfreilich merged commit fe849c8 into main Jan 19, 2021
@dfreilich dfreilich deleted the verbose-codecov branch January 19, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov is not uploading Windows report
1 participant