Use load hooks for monkey_patch loading #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ActiveSupport.on_load(:action_view)` is technically how we're supposed to extend ActionView::Base and other Action View classes, but we weren't doing that for our monkey patches. We could add a `ActiveSupport.on_load(:action_view)` load hook for each extension, but it feels cleaner to let the top level file handle that set up. This then also moves the helper require to the same place for parity.
kaspth
added a commit
that referenced
this pull request
Sep 6, 2022
* main: Ignore /tmp if you're running BT in tmp/starter like CI does Fix some CHANGELOG issues and refit some examples + words Skip needless CI steps (#60) We don't need to depend on sqlite3 that was for an earlier version of the ViewComponent integration Fix #54 to use new section yield syntax Mixing `yield` call styles (#54) Expose Sections as an alternative to `content_for` (#57) Introduce Capybara to the test suite (#55) Add `content_from` to let partials relay contents (#53) v0.1.9 v0.1.8 Document release 🎉 (#52) Rename `Partial#output_buffer` to `Partial#yield` (#41) Allow outer partial access when capturing (#49) Fix accessing `partial` before rendering leaks state (#47) Use load hooks for monkey_patch loading (#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport.on_load(:action_view)is technically how we're supposedto extend ActionView::Base and other Action View classes, but we weren't
doing that for our monkey patches.
We could add a
ActiveSupport.on_load(:action_view)load hook for eachextension, but it feels cleaner to let the top level file handle that
set up.
This then also moves the helper require to the same place for parity.