Mixing yield call styles

[seanpdoyle]

Mixing yield call styles

Follow-up to #41
Follow-up to #51

While the changes introduced in #41 work in theory and pass the tests
written for the alias, they fail to work in practice.

Whenever a Partial#yield call without arguments is made in the same
partial as a Partial#yield call with arguments, the content of the
Partial#yield call made with a name is ignored.

Likewise, when a Partial#yield call is made with an object argument,
without a name, it raises an exception:

Error:
RendererTest#test_mixing_Partial#yield_call_styles_with_objects_renders_all_captured_content:
ActionView::Template::Error: wrong number of arguments (given 1, expected 0)
    [REDACTED]/lib/ruby/gems/3.1.0/gems/activesupport-7.0.3/lib/active_support/core_ext/object/blank.rb:25:in
`present?'
    [REDACTED]/lib/ruby/gems/3.1.0/gems/activesupport-7.0.3/lib/active_support/option_merger.rb:28:in `method_
missing'
    [REDACTED]/bullet-train-co/nice_partials/lib/nice_partials/partial/section.rb:37:in `concat'
    [REDACTED]/bullet-train-co/nice_partials/lib/nice_partials/partial/section.rb:24:in `write_content_for'
    [REDACTED]/bullet-train-co/nice_partials/lib/nice_partials/partial/section.rb:8:in `content_for'
    [REDACTED]/bullet-train-co/nice_partials/lib/nice_partials/partial.rb:46:in `content_for'
    [REDACTED]/bullet-train-co/nice_partials/lib/nice_partials/partial.rb:27:in `yield'
    [REDACTED]/bullet-train-co/nice_partials/test/fixtures/yields/_mixed_with_object.html.erb:2:in `___[REDACTED]_bullet_
train_co_nice_partials_test_fixtures_yields__mixed_with_object_html_erb___1507586996035634049_1460'

This commit adds two failing tests to the suite.

To help troubleshoot this behavior (and to introduce it to the test
harness!), this commit adds a dependency on Capybara, and includes the
Capybara::Minitest::Assertions module into NicePartials::Test.

Ignore . when scanning templates for yield

First, the issue between Partial#output_buffer and Partial#yield is
rooted in the NicePartials::PartialRendering#has_capturing_yield?
check's \byield[\(? ]+(%>|[^:]) regular expression.

The "working" partial passes the regular
expression, which does not detect
a bare yield call:

<div id="mixed_yield">
  <%= partial.yield :slot %>
  <%= partial.output_buffer %>
</div>

A partial with a bare yield call does not pass the regular
expression, since it detects the
bare yield call:

<div id="mixed_yield">
  <%= partial.yield :slot %>
  <%= yield %>
</div>

Unfortunately, a partial with partial.yield also does not pass the
regular expression:

<div id="mixed_yield">
  <%= partial.yield :slot %>
  <%= partial.yield %>
</div>

The \b word boundary in the regular expression isn't treating
partial.yield any differently than yield. Replacing the \b with
/[^\.\b] seems to do the trick.

[seanpdoyle]

I'm not sure how to best troubleshoot this issue, so this is part bug report, part proposal.

[kaspth]

Interesting — yeah, this probably needs some thought. Though it also raises my concerns about furthering Rails' multiple use cases of yield in Nice Partials. @seanpdoyle since you've looked into this, would an alternative name to output_buffer remedy this as well?

[kaspth]

I had no idea that \b in the regex wouldn't be enough.

Glad we figured this out ❤️

[kaspth]

I've noted some issues since #57, but I'll merge and fix those on main.

[kaspth]

Done in e1a5c7f