Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Capybara to the test suite #55

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

seanpdoyle
Copy link
Collaborator

Add a dependency on Capybara, and includes the
Capybara::Minitest::Assertions module into NicePartials::Test.

Add a dependency on Capybara, and includes the
[Capybara::Minitest::Assertions][] module into `NicePartials::Test`.

[Capybara::Minitest::Assertions]: https://rubydoc.info/github/teamcapybara/capybara/master/Capybara/Minitest/Assertions
Copy link
Contributor

@kaspth kaspth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little conflicted about this at first, but it does feel nice to lean on Capybaras assertion helpers.

test/renderer_test.rb Outdated Show resolved Hide resolved
seanpdoyle and others added 2 commits August 26, 2022 14:16
Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com>
@andrewculver andrewculver merged commit 4135ab0 into bullet-train-co:main Sep 5, 2022
kaspth added a commit that referenced this pull request Sep 5, 2022
* main:
  Introduce Capybara to the test suite (#55)
  Add `content_from` to let partials relay contents (#53)
kaspth added a commit that referenced this pull request Sep 6, 2022
* main:
  Ignore /tmp if you're running BT in tmp/starter like CI does
  Fix some CHANGELOG issues and refit some examples + words
  Skip needless CI steps (#60)
  We don't need to depend on sqlite3 that was for an earlier version of the ViewComponent integration
  Fix #54 to use new section yield syntax
  Mixing `yield` call styles (#54)
  Expose Sections as an alternative to `content_for` (#57)
  Introduce Capybara to the test suite (#55)
  Add `content_from` to let partials relay contents (#53)
  v0.1.9
  v0.1.8
  Document release 🎉 (#52)
  Rename `Partial#output_buffer` to `Partial#yield` (#41)
  Allow outer partial access when capturing (#49)
  Fix accessing `partial` before rendering leaks state (#47)
  Use load hooks for monkey_patch loading (#48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants