Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Allow Alternate Authentication Storage Options #1

Closed
jamesdurrant opened this issue Feb 15, 2018 · 3 comments
Closed

FEATURE: Allow Alternate Authentication Storage Options #1

jamesdurrant opened this issue Feb 15, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jamesdurrant
Copy link

Currently, Taurus uses Cache.ts to store the BhRestToken, etc. Cache.ts uses HTML5 Storage (window.localstorage), which is not available on NodeJS, and therefore prevents Taurus from being used for API User authentication.

Could you please consider providing alternative options to override authentication storage, such as using a database to store variables set by Taurus?

Cheers

@bvkimball
Copy link
Contributor

Cache should fallback to just using InMemory storage if localStorage is unavailable, I will double check this. If you want to use an alternate strategy you can override the storage method in the Cache class.

see https://github.com/bullhorn/taurus/blob/master/src/utils/Cache.ts#L25

I will look into providing some default alternatives.

@bvkimball bvkimball self-assigned this Mar 25, 2018
@bvkimball bvkimball added the enhancement New feature or request label Mar 25, 2018
@martinmicunda
Copy link
Contributor

The bug could be closed once this pull request is merged to master.

@bvkimball
Copy link
Contributor

Closed by #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants