Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Redis-related error types into the redis module #269

Closed
sporkmonger opened this issue Apr 9, 2024 · 1 comment · Fixed by #346
Closed

Move Redis-related error types into the redis module #269

sporkmonger opened this issue Apr 9, 2024 · 1 comment · Fixed by #346
Labels
good first issue Good first issue for newcomers to the project. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Release 0.6.0

Comments

@sporkmonger
Copy link
Contributor

Currently the errors for the redis module live in the top-level of the bulwark-sdk crate rather than being associated with the code that originates these errors.
@sporkmonger sporkmonger added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. good first issue Good first issue for newcomers to the project. labels Apr 9, 2024
@sporkmonger sporkmonger added this to the Release 0.6.0 milestone Apr 9, 2024
@sporkmonger
Copy link
Contributor Author

With HTTP showing up as a separate module, those errors should be in the http module too.

sporkmonger added a commit that referenced this issue Jun 14, 2024
@sporkmonger
Rename SendError and move it into the http module.
3ae52c4 
See #269.
@sporkmonger sporkmonger mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issue for newcomers to the project. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
Release 0.6.0
Development

Successfully merging a pull request may close this issue.

Move Redis error into redis module bulwark-security/bulwark
1 participant
@sporkmonger