Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransformerExtensions.EndTransformAsync() May not dispose of transformer in the case of an exception #2

Closed
bungeemonkee opened this issue Jun 16, 2016 · 1 comment
Closed

TransformerExtensions.EndTransformAsync() May not dispose of transformer in the case of an exception #2

bungeemonkee opened this issue Jun 16, 2016 · 1 comment
Assignees
@bungeemonkee
Labels
bug
Milestone
1.1

Comments

@bungeemonkee
Copy link
Owner

The call to transformer.Dispose() in TransformerExtensions.EndTransformAsync() may not be called in the case of an exception because it is not in a finally block.
@bungeemonkee bungeemonkee added this to the 1.1 milestone Jun 16, 2016
@bungeemonkee bungeemonkee self-assigned this Jun 16, 2016
@bungeemonkee
Copy link
Owner Author

Fixed in commit ddf375c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bungeemonkee bungeemonkee

Labels
bug
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@bungeemonkee