Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is the perk dictionary key an item hash or instance id? #13

Closed
bladefist opened this issue Aug 26, 2017 · 2 comments
Closed

Comments

@bladefist
Copy link

Documented here

I'm curious if the key is an item hash or an item instance id. Thanks!

@vthornheart-bng
Copy link
Contributor

Ah, yes! That is an instance ID - I need to see about adding that to the documentation, finding a place to document it other than the parent is a little tricky because they're implemented via a single generic class under the surface. Another good reason for these dictionaries to be inline instead of listed as individual schema.

@vthornheart-bng
Copy link
Contributor

vthornheart-bng commented Aug 28, 2017

I don't have the time right now to add the metadata needed to make sure this can come through in the generator - for now, you'll have to infer it from the description of the property that's pointing to it. They should say whether they're instance IDs, vendor item indexes etc..

But I'll keep this open so we can loop back to it if we get time.

@vthornheart-bng vthornheart-bng removed their assignment Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants