Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Config Option Causes Data Not To Load #15

Closed
timtutt opened this issue Apr 21, 2020 · 6 comments
Closed

Preview Config Option Causes Data Not To Load #15

timtutt opened this issue Apr 21, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@timtutt
Copy link
Contributor

timtutt commented Apr 21, 2020

Hi -

Just started toying around with react-papaparse, and was trying to pass in the preview options into the config for papa parse like below:

<CSVReader
              onDrop={this.handleOnDrop}
              onError={this.handleOnError}
              addRemoveButton
              onRemoveFile={this.handleOnRemoveFile}
              config={{
                header: this.state.hasHeaderRow,
                dynamicTyping: true,
                preview: 1000
              }}
              style={{minHeight: "200px"}}
            >

Unfortunately when preview is passed my handleOnDrop function is never called. When I remove that option everything works as expected. Am I missing something with this particular functionality?

@Bunlong
Copy link
Owner

Bunlong commented Apr 22, 2020

@timtutt I will fix it, when it done I will let you know. Thanks!

@Eptis
Copy link

Eptis commented Apr 23, 2020

Having the same issue but without drag-and-drop. Let me know If I can help fix it.

@Bunlong
Copy link
Owner

Bunlong commented Apr 24, 2020

@Eptis Yes, you can help to fix it.

@Bunlong Bunlong self-assigned this Apr 30, 2020
@Bunlong
Copy link
Owner

Bunlong commented Apr 30, 2020

@timtutt @Eptis react-papaparse version 3.1.2 has been released with fixing Preview Config Option Causes Data Not To Load. Please kindly check. Could we close the issue? Thanks!

@Bunlong Bunlong added the bug Something isn't working label Apr 30, 2020
@timtutt
Copy link
Contributor Author

timtutt commented Apr 30, 2020

Just updated locally, tested and verified! Thanks much.

@timtutt timtutt closed this as completed Apr 30, 2020
@Bunlong
Copy link
Owner

Bunlong commented May 1, 2020

@timtutt You are welcome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants