-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provided client public key has an incorrect modulus length. Modulus length must be "2048", got "1024" #92
Comments
Thanks for reporting @M0rph3v5 As you've provided a response id I take it that this error came in back from the API and that no exception was thrown in the SDK itself as an actually SDK error ? @michielpost do you mind looking into this one ? |
@OGKevin that's correct, searching provides me with: #26 (comment) Having that same issue, but on .net 4.6 referring to https://github.com/dotnet/corefx/issues/12388 Not sure if that's related at all though, the SecurityUtils seems to handle the RSA key size the correct way. |
I can post the full response if that's useful when I get home. |
@M0rph3v5 no need for full response, thats what the response id is for :P. Ill take a look at this and see whats up. C# is not one of my strongest skills however so any help is appreciated. |
@OGKevin hah makes sense :P, it isn't my strong suit either. I just want to build stuff with it, not run in these vague problems 😅 any luck yet? |
If you change the method public static RSA GenerateKeyPair() {
var rsa = RSA.Create();
rsa.KeySize = RSA_KEY_SIZE;
return rsa;
} to public static RSA GenerateKeyPair() {
var csp = new RSACryptoServiceProvider(RSA_KEY_SIZE);
var rsa = (RSA)csp;
return rsa;
} i think it will work. Maybe this will help to update the SDK. |
@BasvdM thanks for this! Do you mind creating a pull request ? |
@OGKevin I won't mind at all, but I'm all new to Github. What do you mean with pull request and what do I have to do exactly? Sorry for my ignorance... |
@BasvdM i think this explains it well enough: https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/ Also make sure when you make a commit the following is in the commit msg: Let me know if you manage if not ill do it my self 😉 |
Running sdk_csharp 1.0.0 with a .net 4.7 application generates the same errors, still. When is this being fixed? |
…length Fix key generation on .NET Framework. (#92)
Steps to reproduce:
What should happen:
What happens:
Traceback
SDK version and environment
Response id
Extra info:
runs on netstandard,
The text was updated successfully, but these errors were encountered: