.Net 4.6 support

[dmeelker]

I'm really happy to see this SDK is happening! However, I can't use it in it's current form because we (my company) are still on .net 4.6. I imagine there's quite a lot of people who will run into this issue. Are there any plans for supporting the normal .NET framework as well as .NET core?

[Toolenaar]

I have the same issue. I also need to use this on .net 4.6. Any plans on including support in the sdk? And if so is there an ETA?

[OGKevin]

Hey @Toolenaar and @dmeelker ill try to aim for this in 0.13.0

[robinvanpoppel]

Thanks for providing this SDK! I'm targeting 4.6 (also tried 4.7) as well and have trouble calling the API. I'm currently running 0.12.4-beta nuget package and run into trouble while establishing an ApiContext.

I get the following exception which seems to happen because of this issue dotnet/corefx#12388

Bunq.Sdk.Exception.BadRequestException: 'Provided client public key has an incorrect modulus length. Modulus length must be "2048", got "1024"'

[OGKevin]

Hey @robinvanpoppel,

Thanks for reporting!

The c# SDK was initially build on/with

dotnet --version
1.1.4              

🙈. There is ATM only 1 issue that is blocking the 0.12.5 release which is bunq/sdk_java#25. The HTTP library used needs to be refactored out. Ill try my best to get this done this weekend! Afterwards ill tackle this issue to bumb the dotnet version support to the latest.

[nduijvelshoff]

Hi any progress updates on this topic? Willing to use in a Azure Function app, but this requires .net461.

[OGKevin]

@nduijvelshoff no not yet. I did some short research before bunq update 7 but could't figure it out in time for the release, hence it missed the 0.13.0 milestone. Im not iterating over the java SDK, c# would be next in line. Help to solve this issue is highly appreciated as my c# knowledge is low compared to the other 3 SDK's.

[jrijkens]

Hi , im new to GitHub but I managed to add .net461 to the sdk
if your interested I can send you the source

[OGKevin]

@jrijkens i dont understand ? How did you manage to add .net461 support if you dont have access to the source ?

[jrijkens]

@OGKevin
let me explain, I went to https://github.com/bunq/sdk_csharp/ en pressed the download clone button and downloaded the source. i could do that without having a github account.

after that i made changes to the local copy so it targets both net core and .net461
in the bunqSDK.csproj file I changed the node

<TargetFramework>netstandard1.5<TargetFramework>
to
<TargetFrameworks>netstandard1.5;net461</TargetFrameworks>

this may also solve your issue for adding netstandard2.0 by just changing it to
<TargetFrameworks>netstandard1.5;netstandard2.0 ;net461</TargetFrameworks>
and resolving any missing refferences

added a couple of missing references with nuget package manager
then fixed the Provided client public key has an incorrect modulus length. Modulus length must be "2048", got "1024" bug with the solution provided by BasvdM on 2 May

the samples are now working with net461

i thought you might be interrested so i created a github account to share this.

[penumbra23]

@jrijkens Just push your branch (let's say feature/net461-support), go here Pull Requests > New Pull Request and target the develop branch. If @OGKevin is willing to check it ofc 😄

I've made a port for the 0.12.4-beta version few months ago but didn't want to disturb the crew as they are implementing new features and the 0.13 update introduced some changes.

My company and many others I believe need the NET Framework support urgent, so it would be awesome if the feature gets merged and published on NuGet soon.

Btw, nice work you guys doing at Bunq, ❤️ the API 👍