Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#25 Update directory for composer scripts, also omit version. #26

Merged
merged 3 commits into from
Aug 7, 2017

Conversation

qurben
Copy link
Contributor

@qurben qurben commented Aug 7, 2017

No description provided.

@OGKevin
Copy link
Contributor

OGKevin commented Aug 7, 2017

#25

@cafferata
Copy link
Contributor

See also; #25 (comment)

Copy link
Contributor

@dnl-blkv dnl-blkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@dnl-blkv dnl-blkv merged commit 7e8432f into develop Aug 7, 2017
@dnl-blkv dnl-blkv deleted the 25-composer-scripts branch August 7, 2017 08:49
@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 7, 2017

@LauLaman we've made a decision to delete the composer.lock. You were right on this one!

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 7, 2017

@andrederoos composer.lock is ignored in the libraries installed via composer. Therefore, every end user of our SDK will use it with their own unique set of versions of packages. Thus, it makes no sense for us to keep track of the composer.lock here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants