Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes since v1.13.0 #142

Closed
angelomelonas opened this issue Aug 11, 2020 · 0 comments · Fixed by #143
Closed

Breaking changes since v1.13.0 #142

angelomelonas opened this issue Aug 11, 2020 · 0 comments · Fixed by #143

Comments

@angelomelonas
Copy link
Contributor

Due to this refactor, there are some breaking changes to this SDK. The following is a list of imports that have to be updated by SDK users as of version 1.13.0:

  • from bunq.sdk.client import Pagination -> from bunq import Pagination
  • from bunq.sdk.context import BunqContext -> from bunq.sdk.context.bunq_context import BunqContext
  • from bunq.sdk.context import ApiContext -> from bunq.sdk.context.bunq_context import ApiContext
  • from bunq.sdk.context import ApiEnvironmentType -> from bunq.sdk.context.api_environment_type import ApiEnvironmentType
  • from bunq.sdk.context import InstallationContext -> from bunq.sdk.context.installation_context import InstallationContext

ApiContext now has to be imported as follows:

  • from bunq.sdk.context.bunq_context import ApiContext

And finally,ApiContext should now be initialised as follows (using the create metthod):

  • api_context = ApiContext.create(ENVIRONMENT_TYPE, API_KEY, DEVICE_DESCRIPTION)

Many thanks to @MarcellaJP for creating the list of broken imports above here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant