Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ValueError isntead of JsonDecodeError. (bunq/sdk_python#72) #83

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Use ValueError isntead of JsonDecodeError. (bunq/sdk_python#72) #83

merged 2 commits into from
Apr 12, 2018

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Apr 7, 2018 •
edited
Loading

References #72

needs #81

@OGKevin OGKevin added this to the 0.13.5 milestone Apr 7, 2018
@OGKevin OGKevin self-assigned this Apr 7, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Apr 7, 2018
@OGKevin OGKevin moved this from To do to open PR in 1.0.0 - SDK Apr 7, 2018
JordyHeemskerk
JordyHeemskerk approved these changes Apr 12, 2018
View reviewed changes
Copy link

@JordyHeemskerk JordyHeemskerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OGKevin OGKevin merged commit a129195 into develop Apr 12, 2018
1.0.0 - SDK automation moved this from open PR to merged Apr 12, 2018
@OGKevin OGKevin deleted the fix_import_error_json_decode_bunq/sdk_python#72 branch April 12, 2018 17:12
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 12, 2018

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordyHeemskerk JordyHeemskerk JordyHeemskerk approved these changes

Assignees

@OGKevin OGKevin

Labels
Can be merged
Projects
No open projects
1.0.0 - SDK
  
merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OGKevin @JordyHeemskerk