Optimise test framework auto topup bunq/sdk_python#78 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test_framework_auto_topup_bunq/sdk_python#78
OGKevin
commented
Apr 6, 2018
tests/bunq_test.py
Outdated
| """ | ||
| :type _second_monetary_account: endpoint.MonetaryAccountBank | ||
| :type _cash_register: endpoint.CashRegister | ||
|
|
There was a problem hiding this comment.
This new line can go
|
@JordyHeemskerk please 👀 |
JordyHeemskerk
requested changes
Apr 6, 2018
bunq/sdk/util.py
Outdated
| :rtype: endpoint.SandboxUser | ||
| """ | ||
|
|
||
| url = "https://sandbox.public.api.bunq.com/v1/sandbox-user" |
There was a problem hiding this comment.
Please use: ApiEnvironmentType.SANDBOX.uri_base instead of https://sandbox.public.api.bunq.com/v1/
bunq/sdk/util.py
Outdated
| url = "https://sandbox.public.api.bunq.com/v1/sandbox-user" | ||
|
|
||
| headers = { | ||
| 'x-bunq-client-request-id': "uniqueness-is-required", |
There was a problem hiding this comment.
Use ApiClient.HEADER_ for this, and then extract the values as wel
bunq/sdk/util.py
Outdated
|
|
||
| import requests | ||
|
|
||
| from bunq.sdk.context import ApiContext, ApiEnvironmentType |
bunq/sdk/util.py
Outdated
| 'x-bunq-region': "en_US", | ||
| } | ||
|
|
||
| response = requests.request("POST", url, headers=headers) |
bunq/sdk/util.py
Outdated
|
|
||
| response = requests.request("POST", url, headers=headers) | ||
|
|
||
| if response.status_code is 200: |
tests/bunq_test.py
Outdated
|
|
||
| def __set_second_monetary_account(self): | ||
| response = endpoint.MonetaryAccountBank.create( | ||
| 'EUR', |
tests/bunq_test.py
Outdated
| Catches BunqException if the conf file does not exist. | ||
| def __request_spending_money(self): | ||
| endpoint.RequestInquiry.create( | ||
| object_.Amount('500', 'EUR'), |
tests/bunq_test.py
Outdated
| endpoint.RequestInquiry.create( | ||
| object_.Amount('500', 'EUR'), | ||
| object_.Pointer('EMAIL', 'sugardaddy@bunq.com'), | ||
| 'sdk python test, thanks daddy <3 - OG', |
There was a problem hiding this comment.
double space between sdk and python, also remove - OG to keep in line with PHP.
tests/bunq_test.py
Outdated
| :rtype: context.ApiContext | ||
| """ | ||
|
|
||
| filename_bunq_config_full = (cls._get_directory_test_root() + | ||
| cls._FILENAME_BUNQ_CONFIG) | ||
| util.automatic_sandbox_install('bunq-test.conf') |
tests/bunq_test.py
Outdated
| cls._DEVICE_DESCRIPTION, []) | ||
| else: | ||
| api_context.ensure_session_active() | ||
| return object_.Pointer('EMAIL', 'bravo@bunq.com') |
This was referenced Apr 8, 2018
OGKevin
deleted the
optimise_test_framework_auto_topup_bunq/sdk_python#78
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues:
must be merged after #80