-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a python linting testing for our repository #33
Comments
I am using flake8 for now. Below is my config refer to the pytorch python linting.
pip3 install flake8 flake8-mypy flake8-bugbear flake8-comprehensions flake8-executable flake8-pyi mccabe pycodestyle pyflakes
[flake8]
select = B,C,E,F,P,T4,W,B9
max-line-length = 120
# C408 ignored because we like the dict keyword argument syntax
# E501 is not flexible enough, we're using B950 instead
ignore =
E203,E305,E402,E501,E721,E741,F403,F405,F821,F841,F999,W503,W504,C408,E302,W291,E303,
# these ignores are from flake8-bugbear; please fix!
B007,B008,
# these ignores are from flake8-comprehensions; please fix!
C400,C401,C402,C403,C404,C405,C407,C411,
per-file-ignores = __init__.py: F401
exclude = docs/src,venv,third_party,caffe2,scripts,docs/caffe2,torch/lib/include,torch/lib/tmp_install,build,torch/include,*.pyi,.git |
I tried to add this repo to Travis CI, sadly and found that I don't have enough rights to enable this repo on Travis. Maybe it is great to enable the CI by the owner, and we just modify the I did my efforts under the following steps:
|
Yes, it seems that only the repo owner can enable it. I'll try to make it work later, please get your configure file ready to go! |
Okay I will get it ready recently.
|
Awesome, so happy to see that, the file will be ready to go recently. |
It is very important to keep the coding style of the whole codebase to be consistent through all the team members because it will help us to read the code more easily.
To be added to the CI.
The text was updated successfully, but these errors were encountered: