Rename "All" to "All Known Communities"

[ShadowJonathan]

After seeing this post, I think it'd be good to clarify that "All" does not mean "All Servers", but "All Known Communities", which is limited by the local server, and all the communities that any local user has subscribed to.

[jiannazzone]

I'll take this one as my first task if it's not already in progress. I have some solo Swift apps, but no experience working as part of a team like this.

[ghost]

@ShadowJonathan like this? just an update to the description?

[ShadowJonathan]

No, change "All Communities" to "Known Communities", and then it'll work

[ghost]

@ShadowJonathan

[Sjmarf]

"All Known Communities" would work better imo.

[ghost]

Yea, I would totally be fine with a description change personally versus changing the headline.

But I just wanna clarify the feed name versus the communities name, as they're intrinsically linked thru an enum. I'd just have to work around it depending on the names.

@ShadowJonathan what would the end names be.

Communities .all =
Feed .all =

[ShadowJonathan]

Known, the problem with "all" is that it reinforces the idea that the local server (or app) is enumerating all communities "on Lemmy", while that isn't the case.

Description is fine, but imo All -> Known.

Possibly "All Known" for the feed header would work, yeah.

[Sjmarf]

Known, the problem with "all" is that it reinforces the idea that the local server (or app) is enumerating all communities "on Lemmy", while that isn't the case.

Description is fine, but imo All -> Known.

Possibly "All Known" for the feed header would work, yeah.

The reason why I think we should retain the word 'all' is for consistency with Lemmy-ui. "All known communities" is clear enough imo.

[ShadowJonathan]

Ah, in that case i think "All Known" across the board could be better. I was a bit afraid that "All" in this instance would simply shortcut someone into thinking that it is "All", not "All Known"

Sorry for the churn, "All Known" it is.

[ghost]

TA-DA!

[ghost]

May I be assigned this task, this is my first contribution.

[EricBAndrews]

Fixed in #274