[burn-import] Add other DataType by conversion to i32 #915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks
script has been executed.Related Issues/PRs
Changes
The current burn-import main dosent' implement any other data types than int32.
Instead it marks it as TODO with a note abour converting to i32
https://github.com/burn-rs/burn/blob/96524d40a1cffc8c13394f70775ce53d5a1abd3b/burn-import/src/onnx/proto_conversion.rs#L37-L40
This fills out that todo by converting to i32.
Testing
Should I also for example make any adjustments to the cast nodes