Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if LOGIN is a refresh #1151

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Check if LOGIN is a refresh #1151

merged 1 commit into from
Dec 3, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Dec 3, 2017

This fixes issue with SSR preventing user to sign in.

Changes:

  • Add meta.refresh to action to inform reducers that this is refresh and doesn't contain reducer.
  • If meta.refresh is set to true don't update state.

@bonustrack bonustrack temporarily deployed to busy-master-pr-1151 December 3, 2017 21:46 Inactive
bonustrack
bonustrack approved these changes Dec 3, 2017
View reviewed changes
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@Sekhmet Sekhmet requested a review from jm90m December 3, 2017 21:55
@Sekhmet Sekhmet merged commit 7d2ca15 into busyorg:master Dec 3, 2017
@Sekhmet Sekhmet deleted the user-logged-in branch December 3, 2017 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm90m jm90m jm90m approved these changes

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sekhmet @jm90m @bonustrack