Add Search for Busy that searches within the site #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uses askSteem API for now * Fixes: #1183 * Add search reducers & search components
|
will merge after @Sekhmet approves |
Sekhmet
reviewed
Dec 13, 2017
src/client/helpers/apiHelpers.js
Outdated
| SteemAPI.sendAsync('lookup_accounts', [name, limit]); | ||
|
|
||
| export const getAllSearchResultPages = search => Promise.all([ | ||
| fetch( |
There was a problem hiding this comment.
I think it would be nice to have loop that would create array of promises instead of hardcoding those.
src/client/search/searchActions.js
Outdated
|
|
||
| return _.reverse(_.sortBy(mergedResults, ['type', 'created'])); | ||
| }) | ||
| .catch(() => dispatch({ type: SEARCH_ASK_STEEM.ERROR })), |
There was a problem hiding this comment.
Wouldn't it dispatch anyway if we will remove catch?
There was a problem hiding this comment.
I'm not sure tbh, will it?
Sekhmet
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1183
Changes:
We are limited on the data that askSteem has and it is sometimes not accurate, for example when it returns a user:
The users post_count, followers_count, following_count is different then the actual values... so I decided not display it