Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vote value #2142

Closed
wants to merge 1 commit into from
Closed

fix vote value #2142

wants to merge 1 commit into from

Conversation

economicstudio
Copy link
Collaborator

fix vote value due to

  1. incorrect voting power incorrect vote value due to incorrect voting power #2139
  2. incorrect total shares incorrect vote value due to incorrect total shares for a user powering down #2141

Fixes #2139, #2141

Changes

Summary of changes you made.

  • Correct voting power for a user who hasn't voted for a while
  • Correct total shares for a user powering down

Test plan

  • Pick any user who hasn't voted for a while and powering down, e.g., Ned
  • See if the vote value is shown correctly. Compare with steempeak, for instance.

Demo

https://busy.org/@ned Before the fix

After the fix (on my local dev server)

Comparison with https://steempeak.com/@ned

@economicstudio
fix vote value
b29a4d7 
fix vote value due to
1. incorrect voting power #2139
2. incorrect total shares #2141
@economicstudio economicstudio mentioned this pull request Dec 30, 2018
Closed
@economicstudio economicstudio deleted the fix-vote-value branch December 30, 2018 02:26
@economicstudio economicstudio restored the fix-vote-value branch December 30, 2018 02:32
@economicstudio
Copy link
Collaborator Author

This one is replaced by #2143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Awaiting requested review from Sekhmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect vote value due to incorrect voting power
1 participant
@economicstudio