Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vote value #2143

Closed
wants to merge 1 commit into from
Closed

fix vote value #2143

wants to merge 1 commit into from

Conversation

economicstudio
Copy link
Collaborator

@economicstudio economicstudio commented Dec 30, 2018 •
edited by Sekhmet
Loading

fix vote value due to

  1. incorrect voting power incorrect vote value due to incorrect voting power #2139
  2. incorrect total shares incorrect vote value due to incorrect total shares for a user powering down #2141

Fixes #2139, #2141

Changes

Summary of changes you made.

  • Correct voting power for a user who hasn't voted for a while
  • Correct total shares for a user powering down

Test plan

  • Pick any user who hasn't voted for a while and powering down, e.g., Ned
  • See if the vote value is shown correctly. Compare with steempeak, for instance.

Demo

https://busy.org/@ned Before the fix

After the fix (on my local dev server)

Comparison with https://steempeak.com/@ned

@economicstudio
fix vote value
0f5a69c 
fix vote value due to

incorrect voting power busyorg#2139
incorrect total shares busyorg#2141
This was referenced Dec 30, 2018
Closed
Closed
@economicstudio
Copy link
Collaborator Author

@Sekhmet Sorry if you received multiple notations. I've combined too issues and made this fix. Thanks!

@economicstudio economicstudio mentioned this pull request Dec 30, 2018
Closed
2 tasks
@economicstudio economicstudio mentioned this pull request Jan 7, 2019
Open
@Sekhmet Sekhmet changed the base branch from master to develop January 17, 2019 10:47
Sekhmet
Sekhmet approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sekhmet
Copy link
Contributor

Sekhmet commented Jan 17, 2019

I can't rebase this PR because you don't allow edits on your repo.
I will apply those changes as a patch.

@Sekhmet
Copy link
Contributor

Sekhmet commented Jan 17, 2019

Merged in 87fdca0.

@Sekhmet Sekhmet closed this Jan 17, 2019
@economicstudio
Copy link
Collaborator Author

@Sekhmet Thanks. I've made my repo editable just in case for later changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Sekhmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect vote value due to incorrect voting power
2 participants
@economicstudio @Sekhmet