Add Voting Power Slider #798

Sekhmet · 2017-10-14T12:41:47Z

Voting Power settings.
Save settings with Save button.
Add Voting Power slider depending on settings.
Handle auto Voting Power.
Load previous vote value on that post (if any) and use it as initial value.
Add estimated vote value.
Default slider value.

bonustrack · 2017-10-14T18:13:33Z

I don't think we need the option Enable and disable slider depending on my Voting Power. Who will chose this? Someone either want slider or not want it.

Sekhmet · 2017-10-14T18:16:19Z

It's still WIP.

Sekhmet · 2017-10-14T20:09:25Z

Settings UI has been updated to add Voting Power + added Save button.

Any reviews, ideas, problems so far?
cc: @bonustrack @mynameisek @jm90m

bonustrack · 2017-10-14T20:55:30Z

Wow! there is even tests, great work @Sekhmet! 🥇 Looking good for me.

bonustrack · 2017-10-14T20:57:37Z

I have just 1 feedback, for the english text, should we talk about "upvote" or "like" ? "Voting power" or "Liking power"? ok maybe the last one is too much

Sekhmet · 2017-10-14T21:00:14Z

I think we should use like/dislike across our app. I would use Voting Power though (capitalized this way).

Fixes issue with images not showing up inside storybook

bonustrack · 2017-10-27T20:16:47Z

@Sekhmet

I'm not able to unvote with disabled slider with default voting value.
When slider disabled and there is a a default voting power value (unless it's 100%) there should the % in the tooltip
With the slider, if i choose 0%, it will show me 0.01$ value of upvote which is not correct, should be 0.

jm90m · 2017-10-27T23:58:22Z

src/app/appActions.js


 export const GET_TRENDING_TOPICS = '@app/GET_TRENDING_TOPICS';
 export const GET_TRENDING_TOPICS_START = '@app/GET_TRENDING_TOPICS_START';
 export const GET_TRENDING_TOPICS_SUCCESS = '@app/GET_TRENDING_TOPICS_SUCCESS';
 export const GET_TRENDING_TOPICS_ERROR = '@app/GET_TRENDING_TOPICS_ERROR';

+export const GET_REWARD_FUND = '@app/GET_REWARD_FUND';


I see that we are having to recreate these action types a lot, it might be good to have a helper like what I did here:

busy/src/helpers/stateHelpers.js

Line 106 in 27c72a6

export const createAsyncActionType = type => ({

We can probably go back and refactor the other action types in a seperate PR, keep the lines of code in each file smaller too

…ower

jm90m · 2017-10-28T17:05:22Z

src/components/Slider/Slider.js

+  formatTip = value => (
+    <div>
+      <FormattedNumber
+        style="percent" // eslint-disable-line react/style-prop-object


kinda weird that they chose to use the style prop for this, but I guess thats what the library says to do (https://github.com/yahoo/react-intl/wiki/Components#formattednumber)

jm90m · 2017-10-28T17:11:58Z

src/components/Slider/Slider.js

+        style="percent" // eslint-disable-line react/style-prop-object
+        value={value / 100}
+      />
+      <span style={{ opacity: '0.5' }}>


is inline styles better here than using a className and applying styles from there? I have no preference, just wondering, when to use inline styles vs classNames.

We use this style quite a lot, so I think we should create global translucentText class for this property and use it everywhere it's needed.

jm90m · 2017-10-28T17:15:00Z

src/components/Slider/Slider.less

+    text-align: center;
+
+    &__amount {
+      font-family: "Source Sans Pro", monospace;


might be good to use one of the @font-family variables in custom.less or create a new one

jm90m · 2017-10-28T17:16:53Z

src/components/Story/Story.js

    switch (key) {
      case 'follow':
-        this.props.onFollowClick(this.props.post);
+        this.props.onFollowClick(post);
        return;


Is there a reason to use return here vs break as in all other ones?

No good reason, it was this way before this PR. It's not big change so I will change this here.

jm90m · 2017-10-28T17:21:06Z

src/components/Story/Story.js

@@ -81,36 +98,57 @@ class Story extends React.Component {
    let followText = '';

    if (postState.userFollowed && !pendingFollow) {


There seems to be a lot of logic here in the render function, it might be a good idea to create a helper function within this component called this.getFollowText() or something and have all the logic in there rather then in the render function.

Although I agree with this I don't think that it's related to this PR and working on multiple unrelated pieces in the same PR shouldn't be encouraged. I don't think we should rewrite half of our code base while adding one feature. I think we should work on this in new PR.

yeah good idea, this PR is already pretty big

jm90m · 2017-10-28T17:25:29Z

src/components/Story/Story.js

-        {saving ? <Icon type="loading" /> : <i className="iconfont icon-write" />}
-        <FormattedMessage id="edit_post" defaultMessage="Edit post" />
-      </PopoverMenuItem>];
+      popoverMenu = [


Same thing here, looks like a lot of logic in this render function, it might be good to break it down into its own function maybe this.renderPopoverMenu(), also same with the rebloggedUI logic.

Although I agree with this I don't think that it's related to this PR and working on multiple unrelated pieces in the same PR shouldn't be encouraged. I don't think we should rewrite half of our code base while adding one feature. I think we should work on this in new PR.

jm90m

Had small comments, but looks like they were fixed, and we can do other comments in other PR.

Been playing around with this, seems to be working. great work! It will be good to see this live

…ower

bonustrack

❤️

Sekhmet added 2 commits October 14, 2017 12:52

Add voting power settings

4ad7c5d

Add translations

ac59cf0

Sekhmet added the PR: WIP label Oct 14, 2017

bonustrack temporarily deployed to busy-dev-pr-798 October 14, 2017 12:41 Inactive

Sekhmet added 2 commits October 14, 2017 18:28

Add settings actions and reducer

e557348

Use settings reducer

ebf8408

Sekhmet added 6 commits October 14, 2017 20:27

Save settings

a98077f

Test case when user_metadata does not have settings

011203d

Remove auto voting power from UI

ffb22a9

Save settings to reducer after reload

7edaa3f

Add missing context for image upload error notification

494bfff

Add Saved notification

49638cb

bonustrack temporarily deployed to busy-dev-pr-798 October 14, 2017 19:58 Inactive

Sekhmet added 4 commits October 15, 2017 09:58

Fix storybook styles file

5aa102c

Add .prettierignore

2df0246

Add getImage helper

9b0d74e

Fixes issue with images not showing up inside storybook

Update stories

891f082

bonustrack temporarily deployed to busy-dev-pr-798 October 15, 2017 09:32 Inactive

Sekhmet added 2 commits October 15, 2017 11:36

Use like instead of upvote

70f27fc

Create Slider prototype

3680f2b

bonustrack temporarily deployed to busy-dev-pr-798 October 15, 2017 10:53 Inactive

Merge branch 'new-design' into nd/voting-power

3d151e4

bonustrack temporarily deployed to busy-dev-pr-798 October 27, 2017 19:38 Inactive

Sekhmet changed the title ~~Add voting power~~ Add Voting Power Slider Oct 27, 2017

Sekhmet mentioned this pull request Oct 27, 2017

Create Wallet page #891

Merged

jm90m reviewed Oct 27, 2017

View reviewed changes

Sekhmet added 2 commits October 28, 2017 15:16

Merge branch 'new-design' of github.com:busyorg/busy into nd/voting-p…

461bb5c

…ower

Fix removing like

3638cb3

bonustrack temporarily deployed to busy-dev-pr-798 October 28, 2017 13:53 Inactive

Sekhmet added 2 commits October 28, 2017 16:42

Add defaultVote percent value to tooltip

d15fb68

Fix 0% vote value

88dc532

bonustrack temporarily deployed to busy-dev-pr-798 October 28, 2017 15:12 Inactive

jm90m reviewed Oct 28, 2017

View reviewed changes

jm90m approved these changes Oct 28, 2017

View reviewed changes

Sekhmet added 2 commits October 28, 2017 21:41

Replace return with break

c3dd570

Use @font-family-monospace variable

37bcd62

bonustrack temporarily deployed to busy-dev-pr-798 October 28, 2017 19:49 Inactive

Merge branch 'new-design' of github.com:busyorg/busy into nd/voting-p…

6b2ec82

…ower

bonustrack deployed to busy-dev-pr-798 October 28, 2017 20:00 View deployment

Sekhmet requested a review from bonustrack October 28, 2017 20:04

bonustrack approved these changes Oct 28, 2017

View reviewed changes

Sekhmet merged commit 95d7a5c into new-design Oct 28, 2017

Sekhmet deleted the nd/voting-power branch October 28, 2017 20:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Voting Power Slider #798

Add Voting Power Slider #798

Sekhmet commented Oct 14, 2017 •

edited

Loading

bonustrack commented Oct 14, 2017

Sekhmet commented Oct 14, 2017

Sekhmet commented Oct 14, 2017 •

edited

Loading

bonustrack commented Oct 14, 2017

bonustrack commented Oct 14, 2017

Sekhmet commented Oct 14, 2017

bonustrack commented Oct 27, 2017 •

edited by Sekhmet

Loading

jm90m Oct 27, 2017

jm90m Oct 28, 2017

jm90m Oct 28, 2017

Sekhmet Oct 28, 2017

jm90m Oct 28, 2017 •

edited

Loading

jm90m Oct 28, 2017

Sekhmet Oct 28, 2017

jm90m Oct 28, 2017

Sekhmet Oct 28, 2017

jm90m Oct 28, 2017

jm90m Oct 28, 2017

Sekhmet Oct 28, 2017

jm90m left a comment

bonustrack left a comment

		@@ -81,36 +98,57 @@ class Story extends React.Component {
		let followText = '';

		if (postState.userFollowed && !pendingFollow) {

Add Voting Power Slider #798

Add Voting Power Slider #798

Conversation

Sekhmet commented Oct 14, 2017 • edited Loading

bonustrack commented Oct 14, 2017

Sekhmet commented Oct 14, 2017

Sekhmet commented Oct 14, 2017 • edited Loading

bonustrack commented Oct 14, 2017

bonustrack commented Oct 14, 2017

Sekhmet commented Oct 14, 2017

bonustrack commented Oct 27, 2017 • edited by Sekhmet Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jm90m Oct 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jm90m left a comment

Choose a reason for hiding this comment

bonustrack left a comment

Choose a reason for hiding this comment

Sekhmet commented Oct 14, 2017 •

edited

Loading

Sekhmet commented Oct 14, 2017 •

edited

Loading

bonustrack commented Oct 27, 2017 •

edited by Sekhmet

Loading

jm90m Oct 28, 2017 •

edited

Loading