Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uncovered branches related to file upload #902

Merged
merged 2 commits into from
Oct 26, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Oct 26, 2017

This PR removes uncovered cases (related to old file upload functionality) in user and editor reducers, and removes any state properties that they referenced, so there are no warnings about not existing imports.

This error:

/node_modules/css-loader!./node_modules/postcss-loader/lib?{"ident":"postcss","plugins":[null,null]}!./node_modules/less-loader/dist/cjs.js!./src/styles/base.less
(Emitted value instead of an instance of Error) autoprefixer: /home/sekhmet/Workspace/busy/src/styles/base.less:13206:3: Second Autoprefixer control comment was ignored. Autoprefixer applies control comment to whole block, not to next rules.

is caused by bug in antd and was already fixed in 3.0 alpha (so it will go away after upgrading).

@Sekhmet Sekhmet added the bug label Oct 26, 2017
@bonustrack bonustrack temporarily deployed to busy-dev-pr-902 October 26, 2017 17:41 Inactive
Copy link
Contributor

@jm90m jm90m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, no more warnings 👍

@Sekhmet Sekhmet merged commit af6ce79 into new-design Oct 26, 2017
@Sekhmet Sekhmet deleted the fix/file-upload-warnings branch October 26, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants