-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add avatar lightbox #932
Add avatar lightbox #932
Conversation
@Sekhmet Isn't better to use https://ant.design/components/carousel/ for it and remove |
I don't think this would be good candidate for lightbox, as it is designed as carousel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I actually like the way lightbox looks, only problem with it is that there doesn't seem to be too much community support around it. But it looks good in mobile responsive.. I guess @bonustrack can decide :)
}; | ||
|
||
static defaultProps = { | ||
username: undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to use the default avatar username here? I guess it doesn't matter if it fails on that request then it goes to avatar default image anyways. So your call :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steemconnect
uses different avatar than we use as error fallback. I don't know whether there is username that has avatar set to that default avatar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong username got default avatar example https://img.busy.org/@xxxx123456 . We should not rely on @steemconnect avatar, at some point we will want to have the logo of SC as avatar.
I've updated |
@Sekhmet The image size should not be bigger than the original and also should keep aspect ratio. You can do this by changing the crop style like this: |
Closes #926
Changes:
AvatarLightbox
component that renders avatar and lightbox for that avatar with given image size.