forked from cs3org/reva
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Consolidate all metadata Get's and Set's to central functions. (cs3or…
…g#2512) * Consolidate all metadata Get's and Set's to central functions. In the decomposed FS, access to xattr was spread all over. This patch consolidates that to use either the Node.SetMetadata() or xattrs.Set(). This allows us to hook in indexing for example. * hound and typos * Add changelog. * Some more fixes to use xattrs functions. * Fix function name in tests. * Fix some linting hints. * Even more linter warning fixes * Even more linting issues * And another iteration * Linter I hate you * Use proper Int formatting Co-authored-by: David Christofas <dchristofas@owncloud.com> * Update pkg/storage/utils/decomposedfs/node/node.go Co-authored-by: David Christofas <dchristofas@owncloud.com> * Update pkg/storage/utils/decomposedfs/node/node.go Co-authored-by: David Christofas <dchristofas@owncloud.com> * Update pkg/storage/utils/decomposedfs/xattrs/xattrs.go Co-authored-by: David Christofas <dchristofas@owncloud.com> * again linting * use correct variable in decomposedfs Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: David Christofas <dchristofas@owncloud.com>
- Loading branch information
1 parent
f283b98
commit 65bb12a
Showing
11 changed files
with
213 additions
and
162 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Enhancement: Consolidate xattr setter and getter | ||
|
||
- Consolidate all metadata Get's and Set's to central functions. | ||
- Cleaner code by reduction of casts | ||
- Easier to hook functionality like indexing | ||
|
||
https://github.com/cs3org/reva/pull/2512 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.