Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example result not actual result #18

Closed
HeyndrickxKarel opened this issue May 8, 2020 · 6 comments
Closed

Example result not actual result #18

HeyndrickxKarel opened this issue May 8, 2020 · 6 comments

Comments

@HeyndrickxKarel
Copy link

HeyndrickxKarel commented May 8, 2020

Hi

For an application I'm developing I wanted to use your documented example: "Multiple lists with reorderable-group-for". However, it seems to me that I do not get the same results as in the example.

In the example every reordering action gets logged but when I use the exact same code with the latest version of your package it logs every reordering except for one. It doesn't log the action when you move an item to an empty array. I believe the empty array doesn't trigger the reordering anymore.

I tried this in an application set up like so:
image

With the following dependencies:
image

@3cp
Copy link
Member

3cp commented May 8, 2020

Can you share a repo for me to reproduce the issue?

@HeyndrickxKarel
Copy link
Author

Ofcourse.

https://github.com/HeyndrickxKarel/test-reorderable-repeat

I have also noticed just now that when I use bcx-aurelia-reoderable-repeat version 1.3.0 I get the opposite result. Now inserting into an empty array triggers that array's event. But removing the last element of an array doesn't trigger that array's event.

@3cp
Copy link
Member

3cp commented May 8, 2020

I will test it out tomorrow.

@3cp
Copy link
Member

3cp commented May 8, 2020

Yes, I can repeat your issue. Fixing.

@3cp 3cp closed this as completed in 5f3e9ac May 9, 2020
@3cp
Copy link
Member

3cp commented May 9, 2020

Fixed in v1.3.5.

@HeyndrickxKarel
Copy link
Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants