LovenseCmd Support, Refactor Client API, Add IPC Support #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No protocol parsing currently, will just take any string. YOLO.
Leave liblog and WebSocketListener where they are, as they have major version updates that will require more work later
- Move Client API to using Connectors instead of having WebSockets built in, allowing for different connection types. - Remove JSON Serialization and message numbering from the base client class. These are only needed in connectors that run decoupled connections (network, ipc, etc), and those matters should be handled there. Functionality moved to helper objects that connectors can use. - Sync paradigms to use async/await with exceptions instead of boolean returns - Make events specific, don't require users to discern them from the returned arg types. - Rewrite tests to be readable, compartmentalized, and updatable. Fixes #368, #367, #366
Reimplement Websocket portions of ButtplugWSClient in their own connector class.
qdot
added
applications
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=========================================
Coverage ? 71.91%
=========================================
Files ? 105
Lines ? 5690
Branches ? 450
=========================================
Hits ? 4092
Misses ? 1426
Partials ? 172
Continue to review full report at Codecov.
|
The IPC Server can buffer multiple messages into the same string. We need to be able to read them back out.
qdot
force-pushed
the
line-ending-cleanup
branch
from
7de6397
to
b73832d
Compare
We shouldn't have to figure out whether we've pinged out by reading messages.
Don't listen on socket while other connections are live, just drop.
Make hard object/state lines between where server connections happen and where session management with Buttplug Server lifetime happens.
… idiomatically async WebsocketListener now comes with a client, meaning we can chuck the mess that is Websocket4Net. Also start post-fixing "async" onto functions that are async, and allowing them to take cancellation tokens where possible. This should also get rid of the "Not GET request" error on the websocket, as that is no longer an error in WebsocketListener. We may get some new error, but that should get a new bug to go with it. Fixes #279, #283
Not sure anyone is using this anymore. If they are, we can always bring it back up in another repo. Fixes #448
This should be maintained outside the main codebase
Doesn't work with new Client API, and would rather just start from scratch.
qdot
force-pushed
the
line-ending-cleanup
branch
from
544db71
to
6ad7fbf
Compare
Remove Kiiroo, add connectors
qdot
force-pushed
the
line-ending-cleanup
branch
from
6ad7fbf
to
1728b5d
Compare
LibLog 5 has a breaking change that will take some extra work to bring in.
Just let Roslyn do a ton of automated warning fixes.
Any async call into ButtplugServer should be stoppable from the outside using cancellation tokens. Expose token passing on the public facing API, and thread them through to system calls (like UWP bluetooth) as needed. Fixes #454
ButtplugServer has internal test functions on it that can be on TestServer with no real issues
We don't really need both targets, .Net Standard should be fine for all of them. Fixes #455
Now that Buttplug.Core is .Net Standard only, we can use LibLog 5.0.2. This will still require stopping Stylecop until LibLog supports the auto-generated tag header
Making some changes to our ruleset to make development suck less (shouldn't error on multiple blank lines or comments without spaces, etc), plus actually fixing some stuff.
qdot
force-pushed
the
line-ending-cleanup
branch
from
8c56df2
to
eaa1374
Compare
Some tests in the server tests only exercised core. Make core its own test project
Move the server frontends to similar naming as the client connectors. As all the libraries we use for them are .Net Standard compatible, change projects to using .Net Standard. Fixes #451
Still has some bugs, but connects via playground and controls a Domi, so that's a good start.
Due to the horribleness of having to keep bluetooth connections alive across multiple server lifetimes, we need to be able to pass DeviceManagers to new servers. I hate this.
qdot
force-pushed
the
line-ending-cleanup
branch
from
8dbdceb
to
dbb8fe6
Compare
|
Build passed at https://ci.appveyor.com/project/qdot/buttplug-csharp/build/0.2.3.742 but Appveyor wasn't sending an update ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.