Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: auto config reloading #68

Open
jwhitcraft opened this issue Sep 22, 2018 · 2 comments
Open

*: auto config reloading #68

jwhitcraft opened this issue Sep 22, 2018 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@jwhitcraft
Copy link

Is your feature request related to a problem? Please describe.
Currently if you change the yaml config for the sso-proxy, you have to reload the sso-proxy app itself.

Describe the solution you'd like

  • The sso-proxy should allow for the config file to change, and reload it automatically, so you don't have to reload the sso-proxy every time. This is useful for dynamic environments and when running in kubernetes.

  • Provide a way when running in a kubernetes cluster to have it watch for annotations on a service to have it dynamically generate the config and reload the service when the config is updated.

@shrayolacrayon shrayolacrayon added the papercuts frustrations to fix but not necessarily a bug label Sep 27, 2018
@snebel29
Copy link
Contributor

Hi,
In fact I came back with this same idea for bitly/oauth2_proxy then switched over buzzfeed/sso as the former seems to have been deprecated, I've already started working in a sidecar binary that would watch for kubernetes annotated services to then change the upstream configuration file within the filesystem, but this still will take some time to get something working, to avoid restarting processes, upstream config reloading would be a healthy requirement.

To do so I was thinking on using either SIGHUP or SIGUSR1 to signal to sso-proxy process about the new configuration to be load, how does that sound? is that something that if I pull request, would be accepted?

Cheers

@mreiferson
Copy link
Contributor

mreiferson commented Nov 26, 2018

@jwhitcraft similar to @snebel29's suggestion, there are a number of tools available to provide this functionality independent from sso itself (like confd). I wonder if this kind of functionality ultimately belongs in the "core"?

@mreiferson mreiferson added enhancement New feature or request and removed papercuts frustrations to fix but not necessarily a bug labels Nov 26, 2018
@mreiferson mreiferson changed the title Auto Config Reloading *: auto config reloading Nov 26, 2018
@mreiferson mreiferson added the question Further information is requested label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants