Handle MessageDeleteBulk event #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iopred
reviewed
Dec 28, 2016
| case *MessageDeleteBulk: | ||
| if s.MaxMessageCount != 0 { | ||
| for _, mID := range t.Messages { | ||
| s.MessageRemove(&Message{ID: mID, ChannelID: t.ChannelID}) |
There was a problem hiding this comment.
If we changed MessageRemove to call messageRemoveById() this could be modified to not create a bunch of junk data.
iopred
reviewed
Dec 28, 2016
| @@ -519,12 +519,12 @@ func (s *State) MessageAdd(message *Message) error { | |||
| } | |||
|
|
|||
| // MessageRemove removes a message from the world state. | |||
| func (s *State) MessageRemove(message *Message) error { | |||
| func (s *State) MessageRemove(channelID, messageID string) error { | |||
There was a problem hiding this comment.
Arghh sorry to be a butthole dude. But I didn't want to change the existing API.
There was a problem hiding this comment.
oh woops i misread what you wrote, sorry
jogramming
force-pushed
the
bulk-del-evt
branch
from
c1ede2a
to
33c36fa
Compare
iopred
reviewed
Dec 28, 2016
| } | ||
|
|
||
| // messageRemoveById removes a message by channelID and messageID from the world state. | ||
| func (s *State) messageRemoveById(channelID, messageID string) error { |
There was a problem hiding this comment.
lint is complaining this should be: messageRemoveByID
ErikMcClure
pushed a commit
to ErikMcClure/discordgo
that referenced
this pull request
Aug 4, 2020
* Handle MessageDeleteBulk event * Changed State.MessageRemove to use id's * Revert State.MessageRemove change and add State.messageRemoveById * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.