ChannelMessageSendComplex #349
Conversation
restapi.go
Outdated
| @@ -1332,23 +1324,7 @@ func (s *Session) ChannelMessageSendEmbed(channelID string, embed *MessageEmbed) | |||
| // content : The message to send. | |||
| // embed : The embed data to send. | |||
| func (s *Session) ChannelMessageSendEmbedWithMessage(channelID string, content string, embed *MessageEmbed) (st *Message, err error) { | |||
There was a problem hiding this comment.
Good call, let's kill this method, it was added in develop, I don't care too much to keep it around.
|
We should probably add EditComplex also. |
|
I was going to do that, but Edit doesn't have as many functions and combinations. At all. EDIT: Whatever, it still allows you to combine them. |
restapi.go
Outdated
|
|
||
| err = unmarshal(response, &st) | ||
| return | ||
| func (s *Session) ChannelMessageSendEmbedWithMessage(channelID string, content string, embed *MessageEmbed) (*Message, error) { |
There was a problem hiding this comment.
Let's just kill this guy, WDYT?
There was a problem hiding this comment.
Personally, yes. But it deserves mercy, too. And because I'm the kind of person that likes compatibility.
There was a problem hiding this comment.
I love me some compatibility, but this method never made it to master.
There was a problem hiding this comment.
Ok you're right. I will remove them
message.go
Outdated
| Content string `json:"content"` | ||
| Tts bool `json:"tts"` | ||
| Embed *MessageEmbed `json:"embed"` | ||
| Nounce string `json:"nounce"` |
There was a problem hiding this comment.
Oohh, right. Thanks. Will fix!
* ChannelMessageSendComplex * ChannelMessageEditComplex * I am a murderer. * Travis didn't like that. * I can't spell
I was getting tired of all the ChannelMessageSendThisWithThisAndThisAndThis.
So, well, this is my solution.
I kept the others for compatibility. And
ChannelMessageSendshould always be kept for ease of use.Anyways, I'm unsure whether I should also include
ChannelFileSendin this as well. It'd certainly be useful (sending embeds and files together, maybe).But that's for later.