SetContent #352
SetContent #352
Conversation
|
One problem I see is that you need to set Should I make a getter method? Should I remove the pointer, so it defaults to an empty struct? |
A friend of mine got weird behaviours, such as negative numbers. Now I'm gonna gather everything I can to put an end to this problem once and for all
|
Since I accidently changed my local Here is how it would look in code: |
message.go
Outdated
| Nonce string `json:"nonce"` | ||
| MessageEdit | ||
| Tts bool `json:"tts"` | ||
| Embed *MessageEmbed `json:"embed"` |
There was a problem hiding this comment.
Embed is defined on MessageEdit, you shouldn't need this line.
There was a problem hiding this comment.
Oo right! Missed that! 1 second!
message.go
Outdated
| Nonce string `json:"nonce"` | ||
| MessageEdit | ||
| Tts bool `json:"tts"` | ||
| Embed *MessageEmbed `json:"embed"` | ||
| } | ||
|
|
||
| // MessageEdit stores all parameters you can send with ChannelMessageSendComplex. | ||
| type MessageEdit struct { |
There was a problem hiding this comment.
Is there a better name here? Do we need the MessageEdit? What if we just document that Tts doesn't work when editing? In that way we could just have 'MessageParameters' as the only struct that both ComplexSend and ComplexEdit take.
|
Lint comment errors breaking the build, but this looks good. |
|
Already on it ;) |
message.go
Outdated
| // MessageParams is used in MessageSend and MessageEdit to share common parameters. | ||
| type MessageParams struct { | ||
| Content *string `json:"content,omitempty"` | ||
| Embed *MessageEmbed `json:"embed"` |
There was a problem hiding this comment.
SORRY! Last thing! This should be omitempty also.
There was a problem hiding this comment.
Oh, right! No problem!
|
Thanks so much dude! 💯 💯 🥇 |
* SendContent * Fixed error...? * Commented * Yep let's do that * Oops * Oki * Whatever you say, Travis... :< * Omit them empty structs
See #351