Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji improvements #786

Merged
merged 3 commits into from
Jun 28, 2020
Merged

Emoji improvements #786

merged 3 commits into from
Jun 28, 2020

Conversation

robbiet480
Copy link
Contributor

@robbiet480 robbiet480 commented Jun 26, 2020 •
edited
Loading

  • Re-arrange Emoji to match docs
  • Add new function GuildEmojis to get all the emoji part of a guild.

@robbiet480 robbiet480 marked this pull request as ready for review June 26, 2020 22:36
@CarsonHoffman
Copy link
Collaborator

Hi, thanks for the PR! We actually had a PR come in right before yours that added the User field, however your other changes still seem worthwhile! I would vote for using Emojis as the terminology; although this might be dubious from a language perspective it would help to keep it in line with other usages in the library, making it clear that it's talking about the plural. If you're able to rebase your PR onto the up-to-date version of develop and take out the addition of the User field, as well as move to Emojis, LGTM!

@robbiet480
Copy link
Contributor Author

Sure thing, just give me a few minutes and I'll get it done!

@robbiet480
Copy link
Contributor Author

@CarsonHoffman All done and ready for merge.

@CarsonHoffman
Copy link
Collaborator

Great, thanks for the quick update and for the PR as a whole!

@CarsonHoffman CarsonHoffman merged commit 928baab into bwmarrin:develop Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbiet480 @CarsonHoffman