feat: Implement oneof tag #103
Conversation
…attern to the other userDefined<type> functions); rearrange and add tests;
…o validate these scenarios
…colon separated values doesn't matter;
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 94.79% 94.95% +0.15%
==========================================
Files 10 10
Lines 1019 1050 +31
==========================================
+ Hits 966 997 +31
Misses 29 29
Partials 24 24
Continue to review full report at Codecov.
|
|
Can you resolve the conflict, please? I can't merge to your PR |
|
oh yes of course! my apologies, I didn't notice that. |
|
@bxcodec my apologies, I didn't notice the conflicts somehow. I just caught my branch up with your master, and fixed the merge conflicts! |
| @@ -113,6 +113,9 @@ const ( | |||
| BoundaryEnd = "boundary_end" | |||
| Equals = "=" | |||
| comma = "," | |||
| colon = ":" | |||
There was a problem hiding this comment.
Are there any reasons why we choose colon for separator?
From the issue, he expects some kind of foo,bar,x,y I'm okay with either, but it will be great if we also considering the user experience?
How usually people separate a list of items? 🤔
There was a problem hiding this comment.
yeah I thought about that. I can switch it if you want. I basically was lazy and didn't want to do the work to make oneof: value1, value2, value3. I didn't have an actually good reason for that.
There was a problem hiding this comment.
I have to run an errand for a little bit right now. But when I get back in an hour or 2, I will be happy to make the user experience better.
i.e. support instead oneof: value1, value2, value <- use colon for the oneof tag only. Then use commas to actually separate the "arguments" to the tag.
There was a problem hiding this comment.
@bxcodec I think I have it in place now. It now uses , to separate the "arguments" to the oneof tag
There was a problem hiding this comment.
LGTM, thanks for the pr bro @andrew-werdna
Do you have a plan for other data types in the near of the future?
I'm planning to move this to v3.5.0 with the full support of OneOfTag
|
I'm down for whenever/however I can help. I'm thinking I'll probably contribute the most on weekends. I'm happy to coordinate with you at your convenience. I can wait, or jump in about for |
|
Thanks bro, float will be great as well. But take your time, no rush, I'm in debt for your help 🙏 . I'm merging this now |
faker:"oneof: val1 :val2 :val3"stringandintis suppported