Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Lazy loading for Many relationship #8

Closed
BYK opened this issue Oct 10, 2011 · 1 comment
Closed

Lazy loading for Many relationship #8

BYK opened this issue Oct 10, 2011 · 1 comment
Assignees

Comments

@BYK
Copy link
Owner

BYK commented Oct 10, 2011

In the current implementation, when an api response provides a "continuation url" like GitHub does in the "Link" header under the name of "next", Model._rest_call method calls all the continuation urls iteratively and returns a merged result using the "+" operator. Although this approach is usually good, in some cases like getting all commits of a project, it takes too much time and usually unncessary resources since the needed subset of commits are usually the ones on the first "pages".

What needs to be done is to make this behavior at least optional or to switch to a "lazy loading" model where the current "WrappedList" approach may be replaced with an "iterator" approach. The first part needing change is the Model._rest_call method and the second part is the Many relationship.

@ghost ghost assigned BYK and berkerpeksag Oct 10, 2011
@BYK
Copy link
Owner Author

BYK commented Oct 10, 2011

This issue is a blocker for berkerpeksag/github-badge#8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants