Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Amazon S3 #1

Closed
andrewmenich opened this issue Mar 5, 2019 · 7 comments
Closed

Does not work with Amazon S3 #1

andrewmenich opened this issue Mar 5, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@andrewmenich
Copy link

andrewmenich commented Mar 5, 2019

I know the Readme says it has only been tested locally. I just wanted to share the error stack trace I received when trying with S3 as I thought it might be of some help for future development.

Getting unknown property: craft\awss3\Volume::path in /home/forge/example.com/vendor/yiisoft/yii2/base/Component.php:154

#0 /home/forge/example.com/vendor/bymayo/pdf-transform/src/services/PdfTransformService.php(66): yii\base\Component->__get('path')
#1 /home/forge/example.com/vendor/bymayo/pdf-transform/src/services/PdfTransformService.php(80): bymayo\pdftransform\services\PdfTransformService->getImagePath(Object(craft\elements\Asset), 'path')
#2 /home/forge/example.com/vendor/bymayo/pdf-transform/src/variables/PdfTransformVariable.php(31): bymayo\pdftransform\services\PdfTransformService->url(Object(craft\elements\Asset))
#3 /home/forge/example.com/vendor/twig/twig/lib/Twig/Extension/Core.php(1626): bymayo\pdftransform\variables\PdfTransformVariable->url(Object(craft\elements\Asset))
#4 /home/forge/example.com/vendor/craftcms/cms/src/helpers/Template.php(73): twig_get_attribute(Object(craft\web\twig\Environment), Object(Twig_Source), Object(bymayo\pdftransform\variables\PdfTransformVariable), 'url', Array, 'method', false, false)
#5 /home/forge/example.com/storage/runtime/compiled_templates/2b/2badab135d869102039d87425f0ab544d5ed8ceca3e20a24042ca872a30ad2f7.php(41): craft\helpers\Template::attribute(Object(craft\web\twig\Environment), Object(Twig_Source), Object(bymayo\pdftransform\variables\PdfTransformVariable), 'url', Array, 'method')

Versions:

Craft v3.0.26.1
PDF Transform v1.0.2
Amazon S3 v1.0.8

@bymayo
Copy link
Owner

bymayo commented Mar 6, 2019

Thanks @andrewmenich - Is this when your trying to save the PDF to S3?

@bymayo bymayo added the enhancement New feature or request label Mar 29, 2019
@RyanRoberts
Copy link

@bymayo Just want to add that I'm getting the same problem with DigitalOcean Spaces (compatible with the S3 API), on both uploading a PDF to assets and when trying to render the image on the frontend.

Getting unknown property: vaersaagod\dospaces\Volume::path

@adrienne
Copy link

adrienne commented Nov 2, 2021

@bymayo I also have this error. Any chance of making it work somehow?

@josh-attwood
Copy link

Also having the same issue here. We tend to store all our assets on S3 so would be great if there was a solution to this!

@bymayo
Copy link
Owner

bymayo commented Sep 22, 2022

@josh-attwood Can you confirm if your using Craft 4? It's highly unlikely i'll build this feature in to the Craft 3 version of this project now Craft 4 is available. But the good news is, I've been testing this feature recently so for Craft 4 it should be available soon.

@josh-attwood
Copy link

@bymayo It's currently Craft 3 but we'll be migrating over to Craft 4 in the next couple of weeks. If it'll be available for Craft 4 that would be amazing!

@bymayo
Copy link
Owner

bymayo commented Nov 14, 2022

@josh-attwood Been a long time coming, but this has now been added in to 1.0.8 for Craft 3, and Craft 4 will be coming later on today.

Works with Amazon S3, Servd and Local volumes

@bymayo bymayo closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants