Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jwalk 0.5 #41

Closed
Byron opened this issue Mar 15, 2020 · 1 comment
Closed

Upgrade to jwalk 0.5 #41

Byron opened this issue Mar 15, 2020 · 1 comment
Assignees

Comments

@Byron
Copy link
Owner

Byron commented Mar 15, 2020

Also see if the new feature, client state, can be leveraged.

see Byron/jwalk#7 (comment)

@Byron Byron self-assigned this Mar 15, 2020
@Byron
Copy link
Owner Author

Byron commented Mar 15, 2020

There seems to be a performance regression. To reproduce, do the following:

git clone https://github.com/Byron/dua-cli && \
cd dua-cli && \
git checkout 4990fa4202f2b687ee2476efe0a406fdfe23fd96 && \
cargo run --release -- i ~/

Watch the CPU usage - it starts out using many cores, but quickly degrades to just a single core, as if work stealing doesn't work anymore or works differently.

Compare that to the latest master, which uses jwalk 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant