Fix compile warnings with Rust 1.51

[Byron]

Most of them seem to point at git-config. When seeing unwraps() I recommend making them into '.expect(…)in case it's more like an assertion, or to transform them into errors to be able to use?` instead.

Everything unrelated to git-config I will fix, please let me know @edward-shen if I should use this opportunity to take a first and more thorough look myself and fix them as I go along.

warning: docs for function which may panic missing `# Panics` section
  --> git-config/src/file.rs:70:5
   |
70 | /     pub fn pop(&mut self) -> Option<(Key, Cow<'event, [u8]>)> {
71 | |         let mut values = vec![];
72 | |         // events are popped in reverse order
73 | |         while let Some(e) = self.section.0.pop() {
...  |
93 | |         None
94 | |     }
   | |_____^
   |
note: the lint level is defined here
  --> git-config/src/lib.rs:3:9
   |
3  | #![warn(clippy::pedantic, clippy::nursery)]
   |         ^^^^^^^^^^^^^^^^
   = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
note: first possible panic found here
  --> git-config/src/file.rs:82:55
   |
82 |                         return Some((k, normalize_cow(values.pop().unwrap())));
   |                                                       ^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
   --> git-config/src/file.rs:242:5
    |
242 | /     pub fn value(&self, key: &Key) -> Option<Cow<'event, [u8]>> {
243 | |         let range = self.get_value_range_by_key(key);
244 | |         if range.is_empty() {
245 | |             return None;
...   |
271 | |         )))
272 | |     }
    | |_____^
    |
note: first possible panic found here
   --> git-config/src/file.rs:253:22
    |
253 |                 _ => unreachable!(),
    |                      ^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
    = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

warning: docs for function which may panic missing `# Panics` section
   --> git-config/src/file.rs:288:5
    |
288 | /     pub fn values(&self, key: &Key) -> Vec<Cow<'event, [u8]>> {
289 | |         let mut values = vec![];
290 | |         let mut found_key = false;
291 | |         let mut partial_value = None;
...   |
316 | |         values
317 | |     }
    | |_____^
    |
note: first possible panic found here
   --> git-config/src/file.rs:309:21
    |
309 |                     partial_value.as_mut().unwrap().extend(&**v);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
   --> git-config/src/file.rs:620:5
    |
620 | /     pub fn section<'lookup>(
621 | |         &mut self,
622 | |         section_name: &'lookup str,
623 | |         subsection_name: Option<&'lookup str>,
...   |
626 | |         Ok(self.sections.get(section_ids.last().unwrap()).unwrap())
627 | |     }
    | |_____^
    |
note: first possible panic found here
   --> git-config/src/file.rs:626:12
    |
626 |         Ok(self.sections.get(section_ids.last().unwrap()).unwrap())
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
   --> git-config/src/file.rs:635:5
    |
635 | /     pub fn section_mut<'lookup>(
636 | |         &mut self,
637 | |         section_name: &'lookup str,
638 | |         subsection_name: Option<&'lookup str>,
...   |
644 | |         ))
645 | |     }
    | |_____^
    |
note: first possible panic found here
   --> git-config/src/file.rs:643:13
    |
643 |             self.sections.get_mut(section_ids.last().unwrap()).unwrap(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
   --> git-config/src/file.rs:762:5
    |
762 | /     pub fn remove_section<'lookup>(
763 | |         &mut self,
764 | |         section_name: &'lookup str,
765 | |         subsection_name: impl Into<Option<&'lookup str>>,
...   |
773 | |         self.sections.remove(&id)
774 | |     }
    | |_____^
    |
note: first possible panic found here
   --> git-config/src/file.rs:772:21
    |
772 |             .remove(self.section_order.iter().position(|v| *v == id).unwrap());
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
   --> git-config/src/file.rs:811:5
    |
811 | /     pub fn rename_section<'lookup>(
812 | |         &mut self,
813 | |         section_name: &'lookup str,
814 | |         subsection_name: impl Into<Option<&'lookup str>>,
...   |
824 | |         Ok(())
825 | |     }
    | |_____^
    |
note: first possible panic found here
   --> git-config/src/file.rs:819:18
    |
819 |         let id = id.last().unwrap();
    |                  ^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
   --> git-config/src/file.rs:919:5
    |
919 | /     pub fn get(&self) -> Result<Vec<Cow<'_, [u8]>>, GitConfigError> {
920 | |         let mut found_key = false;
921 | |         let mut values = vec![];
922 | |         let mut partial_value = None;
...   |
955 | |         Ok(values)
956 | |     }
    | |_____^
    |
note: first possible panic found here
   --> git-config/src/file.rs:931:27
    |
931 |             for event in &self.section.get(section_id).unwrap().0[offset..offset + size] {
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:998:5
     |
998  | /     pub fn set_value<'a: 'event>(&mut self, index: usize, input: Cow<'a, [u8]>) {
999  | |         let EntryData {
1000 | |             section_id,
1001 | |             offset_index,
...    |
1010 | |         );
1011 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1006:13
     |
1006 |             self.section.get_mut(&section_id).unwrap(),
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1021:5
     |
1021 | /     pub fn set_values<'a: 'event>(&mut self, input: impl Iterator<Item = Cow<'a, [u8]>>) {
1022 | |         for (
1023 | |             EntryData {
1024 | |                 section_id,
...    |
1038 | |         }
1039 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1033:17
     |
1033 |                 self.section.get_mut(section_id).unwrap(),
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1051:5
     |
1051 | /     pub fn set_owned_values_all(&mut self, input: &[u8]) {
1052 | |         for EntryData {
1053 | |             section_id,
1054 | |             offset_index,
...    |
1065 | |         }
1066 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1060:17
     |
1060 |                 self.section.get_mut(section_id).unwrap(),
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1074:5
     |
1074 | /     pub fn set_values_all<'a: 'event>(&mut self, input: &'a [u8]) {
1075 | |         for EntryData {
1076 | |             section_id,
1077 | |             offset_index,
...    |
1088 | |         }
1089 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1083:17
     |
1083 |                 self.section.get_mut(section_id).unwrap(),
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1114:5
     |
1114 | /     pub fn delete(&mut self, index: usize) {
1115 | |         let EntryData {
1116 | |             section_id,
1117 | |             offset_index,
...    |
1125 | |         }
1126 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1121:13
     |
1121 |             self.section.get_mut(section_id).unwrap().0.drain(offset..offset + size);
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1130:5
     |
1130 | /     pub fn delete_all(&mut self) {
1131 | |         for EntryData {
1132 | |             section_id,
1133 | |             offset_index,
...    |
1142 | |         self.indices_and_sizes.clear();
1143 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1138:17
     |
1138 |                 self.section.get_mut(section_id).unwrap().0.drain(offset..offset + size);
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1195:5
     |
1195 | /     pub fn get_raw_value<'lookup>(
1196 | |         &self,
1197 | |         section_name: &'lookup str,
1198 | |         subsection_name: Option<&'lookup str>,
...    |
1215 | |         Err(GitConfigError::KeyDoesNotExist)
1216 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1210:30
     |
1210 |             if let Some(v) = self.sections.get(section_id).unwrap().value(&key) {
     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1228:5
     |
1228 | /     pub fn get_raw_value_mut<'lookup>(
1229 | |         &mut self,
1230 | |         section_name: &'lookup str,
1231 | |         subsection_name: Option<&'lookup str>,
...    |
1272 | |         Err(GitConfigError::KeyDoesNotExist)
1273 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1242:31
     |
1242 |             for (i, event) in self.sections.get(section_id).unwrap().0.iter().enumerate() {
     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1315:5
     |
1315 | /     pub fn get_raw_multi_value<'lookup>(
1316 | |         &self,
1317 | |         section_name: &'lookup str,
1318 | |         subsection_name: Option<&'lookup str>,
...    |
1337 | |         }
1338 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1324:17
     |
1324 | /                 self.sections
1325 | |                     .get(&section_id)
1326 | |                     .unwrap()
     | |_____________________________^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section
    --> git-config/src/file.rs:1395:5
     |
1395 | /     pub fn get_raw_multi_value_mut<'lookup>(
1396 | |         &mut self,
1397 | |         section_name: &'lookup str,
1398 | |         subsection_name: Option<&'lookup str>,
...    |
1448 | |         }
1449 | |     }
     | |_____^
     |
note: first possible panic found here
    --> git-config/src/file.rs:1413:31
     |
1413 |             for (i, event) in self.sections.get(section_id).unwrap().0.iter().enumerate() {
     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
    --> git-config/src/file.rs:1773:1
     |
1773 | impl<'a> Into<Vec<u8>> for GitConfig<'a> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: `#[warn(clippy::from_over_into)]` on by default
     = help: consider to implement `From` instead
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
    --> git-config/src/file.rs:1779:1
     |
1779 | impl<'a> Into<Vec<u8>> for &GitConfig<'a> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: consider to implement `From` instead
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/parser.rs:130:1
    |
130 | impl Into<Vec<u8>> for Event<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/parser.rs:136:1
    |
136 | impl Into<Vec<u8>> for &Event<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/parser.rs:350:1
    |
350 | impl Into<Vec<u8>> for ParsedSectionHeader<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/parser.rs:356:1
    |
356 | impl Into<Vec<u8>> for &ParsedSectionHeader<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/parser.rs:362:1
    |
362 | impl<'a> Into<Event<'a>> for ParsedSectionHeader<'a> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/parser.rs:415:1
    |
415 | impl Into<Vec<u8>> for ParsedComment<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/parser.rs:421:1
    |
421 | impl Into<Vec<u8>> for &ParsedComment<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:224:1
    |
224 | impl Into<Vec<u8>> for Value<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:230:1
    |
230 | impl Into<Vec<u8>> for &Value<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:376:1
    |
376 | impl Into<bool> for Boolean<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:385:1
    |
385 | impl<'a, 'b: 'a> Into<&'a [u8]> for &'b Boolean<'a> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:394:1
    |
394 | impl Into<Vec<u8>> for Boolean<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:400:1
    |
400 | impl Into<Vec<u8>> for &Boolean<'_> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:492:1
    |
492 | impl<'a, 'b: 'a> Into<&'a [u8]> for &'b TrueVariant<'a> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:617:1
    |
617 | impl Into<Vec<u8>> for Integer {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:623:1
    |
623 | impl Into<Vec<u8>> for &Integer {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:839:1
    |
839 | impl Into<Vec<u8>> for Color {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> git-config/src/values.rs:845:1
    |
845 | impl Into<Vec<u8>> for &Color {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider to implement `From` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into

[...]

[edward-shen]

Wow, Rust 1.51 was released less than two hours ago! I see I'm not the only one excited to play with const generics.

I can take a look at my code later this week (probably tomorrow or Saturday) but feel free to fix them if you'd rather do so yourself and/or prefer them to be fixed sooner.

For the most part the usage of unwrap is generally in situations where I reasoned that it was impossible to reach that situation, so I think fixing most parts should be relatively straightforward.

[Byron]

😅 That was mere chance, but it's always nice to install a new Rust version and fix the additional clippy lints that usually pop up, making everything just a little better.

Even though I really want to take a closer look at git-config, I probably won't make it in time. So no rush for you, it's likely these will still be there when you get to it.

On another note, I hope you are also a little bit excited about the grant opportunity 🎉.

[Byron]

Note to self: Add resolver = "2" and fix all the new warnings that show up with it. I think dua-cli might also benefit from it.

[edward-shen]

git-config should be clean now.

[Byron]

Everything I could find is now fixed as well. Please note that resolver = "2" will be activated a bit later once GitHub CI provides the latest Rust binaries - otherwise cargo fmt will fail, unfortunately, claiming that resolver is a nightly flag. Fair enough :D.