Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Can user change a shared_address's definition by sending a definition_change unit ? #139

Closed
ianhhhhhhhhe opened this issue Nov 1, 2018 · 1 comment

Comments

@ianhhhhhhhhe
Copy link

If I make a shared_address with someone, and we all can use the money in it, so we all can compose unit with this address, right? So I am thinking, if I can compose a definition_change unit to change this shared_address's definition so the other one will no longer be able to use this address.

And another question came out. Whether a shared_address's definition can be used in definition_change unit to be an another address's new definition?

@ianhhhhhhhhe ianhhhhhhhhe changed the title Can user change a shared_address's definition by sending a definition_change unit ? Question: Can user change a shared_address's definition by sending a definition_change unit ? Nov 1, 2018
@Papabyte
Copy link
Contributor

  1. It should be possible.
    If you look at validation code: https://github.com/byteball/byteballcore/blob/a0b18418d14c3b6ea74c1c76d3b749f77213be3d/validation.js#L1152
    Any address that is in objUnit.authors can have its definition changed, whatever it's a shared one or not.

  2. When you create a new definition, only chash is posted in DAG, the definition is posted later when you sign an unit with this address for a first time. So there would be no way to know wether the chash is from a shared_address's definition or not, thus it's certainly possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants