Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.16 had a breaking-change upgrading fs-set-times dependency #324

Closed
alexcrichton opened this issue Jun 30, 2023 · 1 comment
Closed

1.0.16 had a breaking-change upgrading fs-set-times dependency #324

alexcrichton opened this issue Jun 30, 2023 · 1 comment

Comments

@alexcrichton
Copy link
Member

In #321 the cap-primitives crate updated its dependency on fs-set-times from 0.19.x to 0.20.x, but the fs-set-times types are part of the public API of cap-primitives via the from_std and into_std methods, meaning that upgrading a major version of a dependency is a breaking change on behalf of the cap-primitives crate.

This is causing downstream issues where Wasmtime 10.0.1 no longer compiles with crates.io, for example.
@alexcrichton alexcrichton mentioned this issue Jun 30, 2023
Closed
@sunfishcode
Copy link
Member

Confirmed; cap-std 1.0.16 had a breaking change. I've now yanked that version, and the original reported issue in bytecodealliance/wasmtime#6674 is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @sunfishcode