Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS host generator uses native endianness when copying "canonical" lists #26

Open
alexcrichton opened this issue Jul 26, 2021 · 0 comments
Open

JS host generator uses native endianness when copying "canonical" lists #26

alexcrichton opened this issue Jul 26, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@alexcrichton
Copy link
Member

Currently it just uses slices of the underlying array buffer and doesn't attempt to swap endianness, which means that little-endian integers from wasm will be exposed as native-endian integers in JS, which means that on big-endian this will all be backwards.
@alexcrichton alexcrichton mentioned this issue Oct 24, 2022
Merged
@alexcrichton alexcrichton transferred this issue from bytecodealliance/wit-bindgen Jan 26, 2023
@yoshuawuyts yoshuawuyts added the bug Something isn't working label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @yoshuawuyts