Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.39.0] Backport CI fixes #4490


Copy link

This includes an s390x-specific fix for constants but an additional all-platforms fix for the reftyped_vregs array.

This commit fixes an issue introduced as part of the fix for
GHSA-5fhj-g3p3-pq9g. The `reftyped_vregs` list given to `regalloc2` is
not allowed to have duplicates in it and while the list originally
doesn't have duplicates once aliases are applied the list may have
duplicates. The fix here is to perform another pass to remove duplicates
after the aliases have been processed.
This carries over a narrow fix from bytecodealliance#4427 to prior release branches. The
patch here was created by `@uweigand` during the investigation for bytecodealliance#4487.
Copy link
Member Author

@uweigand mind double-checking my backport here as well? (I can't seem to request a review from you through the GitHub UI...)

Copy link

@uweigand mind double-checking my backport here as well?

LGTM, thanks!

(I can't seem to request a review from you through the GitHub UI...)

That's probably because I don't have any commit / approval rights on this repo?

@alexcrichton alexcrichton merged commit 0b0ee24 into bytecodealliance:release-0.39.0 Jul 20, 2022
@alexcrichton alexcrichton deleted the backports-for-release-0.39.0 branch July 20, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants